Merge pull request #340 from edx/alisan/remove-edx-icons-js

Add ESlint and remove edx-icons afontgarde and modernizer files TNL-4902

.eslintignore

@@ -0,0 +1,3 @@
+_preview_site
+_site
+node_modules

.eslintrc.json

@@ -0,0 +1,3 @@
+{
+    "extends": "eslint-config-edx"
+}

gulp/.eslintrc.json

@@ -0,0 +1,5 @@
+{
+    "rules": {
+        "no-console": "off"
+    }
+}

gulp/config.js

@@ -81,6 +81,9 @@ module.exports = {
         demo_src:               demoSrc + '/static/js',
         demo_src_files:         demoSrc + '/static/js/**/*.js'
     },
+    exampleHtmlFiles:           {
+        pldoc_src_files:        pldocSrc + '/_includes/examples/*.html'
+    },
     lib:                    {
         // third party libraries
         src:                    './node_modules'

gulp/tasks/demo_scripts.js

@@ -5,7 +5,7 @@ var gulp            = require('gulp'),
     config          = require('../config').scripts,
     uglify          = require('gulp-uglify');
 
-gulp.task('demo-scripts', ['scripts-lint'], function() {
+gulp.task('demo-scripts', ['lint'], function() {
     return gulp.src([
             // setup script sequence
             config.demo_src + '/pattern-library.js'

gulp/tasks/pldoc.js

@@ -9,7 +9,7 @@ var gulp = require('gulp'),
     ghPages = require('gulp-gh-pages'),
     runSequence = require('run-sequence');
 
-gulp.task('pldoc-scripts', ['scripts-lint'], function() {
+gulp.task('pldoc-scripts', ['lint'], function() {
     return gulp.src([configScripts.pldoc_src + '/**.js'])
         .pipe(uglify())
         .pipe(browserSync.reload({stream: true}))

gulp/tasks/scripts-lint.js

@@ -1,15 +1,23 @@
-'use strict';
+(function() {
+    'use strict';
 
-var gulp            = require('gulp'),
-    config          = require('../config').scripts,
-    handleErrors    = require('../util/handleErrors'),
-    merge           = require('merge-stream');
+    var gulp            = require('gulp'),
+        eslint          = require('gulp-eslint'),
+        config          = require('../config').scripts,
+        htmlFiles       = require('../config').exampleHtmlFiles,
+        handleErrors    = require('../util/handleErrors'),
+        merge           = require('merge-stream');
 
-gulp.task('scripts-lint', function() {
+    gulp.task('lint', function() {
 
-    var scripts = gulp.src(config.src_files),
-        pldocScripts = gulp.src(config.pldoc_src_files);
+        var scripts = gulp.src(config.src_files),
+            pldocScripts = gulp.src(config.pldoc_src_files),
+            pldocHtmlFiles = gulp.src(htmlFiles.pldoc_src_files);
 
-    return merge(scripts, pldocScripts)
-        .on('error', handleErrors);
-});
+        return merge(scripts, pldocScripts, pldocHtmlFiles)
+            .pipe(eslint())
+            .pipe(eslint.format())
+            .pipe(eslint.failAfterError());
+    });
+
+}());

gulp/tasks/scripts.js

@@ -5,7 +5,7 @@ var gulp            = require('gulp'),
     config          = require('../config'),
     uglify          = require('gulp-uglify');
 
-gulp.task('scripts', ['scripts-lint'], function() {
+gulp.task('scripts', ['lint'], function() {
     return gulp.src([
             // setup script sequence
             config.scripts.src + '/select-replace.js',

package.json

@@ -37,12 +37,15 @@
     "css-loader": "~0.23.1",
     "del": "*",
     "edx-ui-toolkit": "~1.4.1",
+    "eslint": "~2.13.1",
+    "eslint-config-edx": "~1.2.0",
     "extract-text-webpack-plugin": "~1.0.1",
     "file-loader": "0.8.5",
     "font-awesome-loader": "0.0.1",
     "gulp": "*",
     "gulp-changed": "*",
     "gulp-concat": "*",
+    "gulp-eslint": "^2.0.0",
     "gulp-filesize": "*",
     "gulp-filter": "*",
     "gulp-gh-pages": "~0.5.4",
@@ -69,6 +72,7 @@
   "scripts": {
     "production": "gulp build-production",
     "gulp": "gulp",
-    "development": "gulp build-development"
+    "development": "gulp build-development",
+    "lint": "gulp lint"
   }
 }