Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(fix): make a test determined #40

Merged
merged 1 commit into from
Nov 10, 2021
Merged

test(fix): make a test determined #40

merged 1 commit into from
Nov 10, 2021

Conversation

nedbat
Copy link

@nedbat nedbat commented Nov 10, 2021

On CI, the data was returned in a different order, so the test failed.

Overview

What do we need to know about this change?

Test Instructions

  • Checkout the branch
  • Update settings?
  • Anything else?

TODO

  • Compile static assets
  • Lint all files
  • Pass all tests
  • Bump the version number in setup.py
  • Attach screenshots?
  • Code Reviewer 1:
  • Code Reviewer 2:
  • Submit PR against edx-platform to bump the version
  • Upload to PyPi

@nedbat
test(fix): make a test determined
82760ce 
On CI, the data was returned in a different order, so the test failed.
@nedbat nedbat requested a review from a team November 10, 2021 22:17
@nedbat nedbat merged commit d8c0ea0 into master Nov 10, 2021
@nedbat nedbat deleted the nedbat/fix-test branch November 10, 2021 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nedbat