Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python Code Cleanup #137

Merged
merged 2 commits into from
Jan 25, 2021
Merged

Python Code Cleanup #137

merged 2 commits into from
Jan 25, 2021

Conversation

edx-requirements-bot
Copy link
Contributor

Python code cleanup by the cleanup-python-code Jenkins job.

This pull request was generated by the cleanup-python-code Jenkins job, which ran

modernize_travis;make upgrade;find . -type f -name '*.py' | while read fname; do pyupgrade --exit-zero-even-if-changed --keep-percent-format --py3-plus --py36-plus --py38-plus "$fname"; done

The following packages were installed:
pyupgrade,git+https://github.com/edx/repo-tools.git@c05453b733602ba7a2224ffbbf58a8d0903b62d8

@coveralls
Copy link

coveralls commented Jan 21, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-98.0%) to 0.0% when pulling 0be65a5 on jenkins/cleanup-python-code-7f3b150 into 7f3b150 on master.

@mraarif mraarif force-pushed the jenkins/cleanup-python-code-7f3b150 branch 3 times, most recently from 10a1604 to ff67344 Compare January 21, 2021 13:09
@mraarif mraarif force-pushed the jenkins/cleanup-python-code-7f3b150 branch from 1df6d6f to 90537d4 Compare January 21, 2021 13:11
nedbat
nedbat suggested changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@nedbat nedbat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little concerned about the number of open PRs in-flight, but it should be OK to merge this after a few improvements. @giovannicimolin may have an opinion also.

lti_consumer/lti_1p1/consumer.py Outdated Show resolved Hide resolved
lti_consumer/lti_1p1/consumer.py Outdated Show resolved Hide resolved
lti_consumer/lti_1p3/extensions/rest_framework/serializers.py Outdated Show resolved Hide resolved
lti_consumer/tests/unit/test_api.py Outdated Show resolved Hide resolved
@UsamaSadiq UsamaSadiq merged commit b80ca5f into master Jan 25, 2021
@UsamaSadiq UsamaSadiq deleted the jenkins/cleanup-python-code-7f3b150 branch January 25, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giovannicimolin giovannicimolin giovannicimolin left review comments

@UsamaSadiq UsamaSadiq UsamaSadiq approved these changes

@nedbat nedbat nedbat approved these changes

@mraarif mraarif Awaiting requested review from mraarif

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@edx-requirements-bot @coveralls @nedbat @giovannicimolin @UsamaSadiq