Additional args to FUN in st_join() don't work

[Robinlovelace]

Reproducible example (on sf_0.4-3 not tested on latest version):

library(sf)
example("st_join")
st_join(a, b, FUN = mean, na.rm = T)

[edzer]

Well, the ... are now passed on to the join function; you can't pass them on to both; in the dev version (which I'm looking at) this is documented. Whether it is a good idea is another question. The thinking was that you could pass on a pattern to st_relate, when that is used to join.

[Robinlovelace]

If it's documented that makes it less of an issue but I still think it's an issue: if people have a FUN argument a logical next step is to pass it args, as with lapply etc.

I see the issue about not being able to pass all ... and am not sure what the best solution to this issue is. If the code above can be made to work, or replaced by a different command that achieves the same result in example("st_join") that would be a benefit for users I think.

[edzer]

We should drop the FUN argument here, and use aggregate.sf directly when you want to aggregate.

…

On 11 June 2017 06:17:50 BST, Robin ***@***.***> wrote: If it's documented that makes it less of an issue but I still think it's an issue: if people have a `FUN` argument a logical next step is to pass it args, as will lapply etc. I see the issue about not being able to pass all `...` and am not sure what the best solution to this issue is. If the code above can be made to work, or replaced by a different command that achieves the same result in `example("st_join")` that would be a benefit for users I think. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #376 (comment)

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[edzer]

I am going to remove the FUN argument, and leave aggregation to sf::aggregate.sf of summarise, so that we can do this, following the example of ?st_join, by

st_join(a, b) %>% aggregate(list(.$a.x), mean)

or

library(dplyr)
st_join(a, b) %>% group_by(a.x) %>% summarise(mean(a.y))

[edzer]

Deprecated arg FUN in st_join in 1db9b59.

[Robinlovelace]

Thanks Edzer, great fix! Will look into docs although probably not until I'm back from travels in July.