Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN submission #112

Closed
edzer opened this issue Nov 14, 2021 · 2 comments
Closed

CRAN submission #112

edzer opened this issue Nov 14, 2021 · 2 comments

Comments

@edzer
Copy link
Owner

edzer commented Nov 14, 2021

Dear maintainer,
 
package sp_1.4-6.tar.gz has been auto-processed. The auto-check found problems when checking the first order strong reverse dependencies.
Please reply-all and explain: Is this expected or do you need to fix anything in your package? If expected, have all maintainers of affected packages been informed well in advance? Are there false positives in our results?
 
*** Changes to worse in reverse dependencies ***
Debian: <https://win-builder.r-project.org/incoming_pretest/sp_1.4-6_20211114_002543/reverseDependencies/summary.txt>
 
Log dir: <https://win-builder.r-project.org/incoming_pretest/sp_1.4-6_20211114_002543/>
The files will be removed after roughly 7 days.
 
Pretests:
Windows: <https://win-builder.r-project.org/incoming_pretest/sp_1.4-6_20211114_002543/Windows/00check.log>
Debian: <https://win-builder.r-project.org/incoming_pretest/sp_1.4-6_20211114_002543/Debian/00check.log>
 
Last published version on CRAN:
 
CRAN Web: <https://cran.r-project.org/package=sp>
 
Best regards,
CRAN teams' auto-check service


Package check result: OK

Changes to worse in reverse depends:

Package: GeoFIS
Check: Rd files
New result: WARNING
  prepare_Rd: rgeos: versions of GEOS runtime 3.10.1-CAPI-1.16.0
  and GEOS at installation 3.10.0-CAPI-1.16.0differ

Package: spNetwork
Check: Rd files
New result: WARNING
  prepare_Rd: rgeos: versions of GEOS runtime 3.10.1-CAPI-1.16.0
  and GEOS at installation 3.10.0-CAPI-1.16.0differ

Package: SSN
Check: contents of ‘data’ directory
New result: WARNING
  Output for data("mf04", package = "SSN"):
    Warning message:
    In fun(libname, pkgname) :
      rgeos: versions of GEOS runtime 3.10.1-CAPI-1.16.0
    and GEOS at installation 3.10.0-CAPI-1.16.0differ
  Output for data("mf04p", package = "SSN"):
    Warning message:
    In fun(libname, pkgname) :
      rgeos: versions of GEOS runtime 3.10.1-CAPI-1.16.0
    and GEOS at installation 3.10.0-CAPI-1.16.0differ
  Output for data("modelFits", package = "SSN"):
    Warning message:
    In fun(libname, pkgname) :
      rgeos: versions of GEOS runtime 3.10.1-CAPI-1.16.0
    and GEOS at installation 3.10.0-CAPI-1.16.0differ

This seems to be an issue in rgeos, shall I say that @rsbivand ?

@rsbivand
Copy link
Contributor

No, it is a check train issue, that rgeos was built with 3.10.0 but run with 3.10.1, unless I'm mistaken. Is Debian now using binary rgeos? The test is:

  if (!isTRUE(all.equal(version_GEOS(TRUE), version_GEOS(FALSE),
    check.attributes=FALSE))) {
    warning("rgeos: versions of GEOS runtime ", c(version_GEOS(TRUE)),
    "\nand GEOS at installation ", version_GEOS(FALSE), "differ")
  }

in rgeos::.onLoad(), and

version_GEOS <- function(runtime=TRUE) {
    stopifnot(is.logical(runtime))
    stopifnot(length(runtime) == 1L)
    res0 <- .Call("rgeos_GEOSversion", runtime, PACKAGE="rgeos")
    res1 <- strsplit(res0, " ")[[1]]
    res <- res1[1]
    if (length(res1) > 1) attr(res, "rev") <- res1[2]
    res
}

and

SEXP rgeos_GEOSversion(SEXP runtime) {

    int rt = LOGICAL_POINTER(runtime)[0];

    SEXP ans;
    PROTECT(ans = NEW_CHARACTER(1));
    if (rt) {
        SET_STRING_ELT(ans, 0, COPY_TO_USER_STRING(GEOSversion()));
    } else {
        SET_STRING_ELT(ans, 0, COPY_TO_USER_STRING(GEOS_CAPI_VERSION));
    }
    UNPROTECT(1);
    return(ans);
}

in the context of

#include <geos_c.h>

@edzer
Copy link
Owner Author

edzer commented Nov 14, 2021

Thanks!

@edzer edzer closed this as completed Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants