Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct evolution 2L for sp::is.projected() #117

Open
rsbivand opened this issue Jun 14, 2022 · 7 comments
Open

Correct evolution 2L for sp::is.projected() #117

rsbivand opened this issue Jun 14, 2022 · 7 comments

Comments

@rsbivand
Copy link
Contributor

rsbivand@397c305 fixes an omitted part of the 2L evolution setting

@rsbivand
Copy link
Contributor Author

I also updated the example in ?gridlines to let the package pass under all three evolution values in my fork, main branch.

@edzer
Copy link
Owner

edzer commented Jun 14, 2022

Thanks! I added rsbivand@397c305 by hand, and cleaned up the code in 684edc9 - hope you like it!

@rsbivand
Copy link
Contributor Author

Thanks! What about the gridlines man page examples? My commit to my fork makes it work, but maybe we could just retain the very first block that doesn't load rgdal and should (?) work for all three evolution status values?

edzer added a commit that referenced this issue Jun 15, 2022
* also passes if _R_CHECK_DEPENDS_ONLY_=true;
@edzer
Copy link
Owner

edzer commented Jun 15, 2022

These changes also meet _R_CHECK_DEPENDS_ONLY_=true, which seems to be coming.

@rsbivand
Copy link
Contributor Author

Maybe also break:

* checking Rd line widths ... NOTE
Rd file 'gridlines.Rd':
  \examples lines wider than 100 characters:
     if (get("evolution_status", envir=sp:::.spOptions) == 2L && requireNamespace("sf", quietly=TRUE)) run <- TRUE
     if (get("evolution_status", envir=sp:::.spOptions) == 0L && requireNamespace("rgdal", quietly=TRUE)) run <- TRUE

edzer added a commit that referenced this issue Jun 15, 2022
@rsbivand
Copy link
Contributor Author

rsbivand commented Jun 15, 2022

Proposed here: rsbivand@d51fb91

This also adds switching the default proj4 datum specs loss warnings from ""all" to "none" as per: https://stat.ethz.ch/pipermail/r-sig-geo/2020-May/028125.html; will update rgdal to 1.6-1 soon and submit.

@rsbivand
Copy link
Contributor Author

And R CMD check with rgdal, rgeos and maptools absent revealed another way around - as was failed because run TRUE but no rgdal: rsbivand@b73d2f3. Check log with this proposed change:
00check.log

edzer added a commit that referenced this issue Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants