Sp210 ready for submission shortly #138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This strips out
rgdal
,rgeos
andmaptools
, leaving exportedget/set_evolution_status
as noops (needed by several packages that use them https://github.com/r-spatial/evolution/blob/main/pkgapi_230811.csv lines 97 and 138 (inlabru plus some not seen by pkgapi)).For present CRAN packages,
CoordinateCleaner
andLabourMarketAreas
fail.CoordinateCleaner
is ropensci/CoordinateCleaner#78 and thenew_spatial
branch pass CMD check with this 2.1-0 with or without retiring packages on the library path.LabourMarketAreas
is harder, I've been in email contact, but itpkgapi
-uses:maptools::unionSpatialPolygons
rgdal::readOGR
rgdal::writeOGR
rgeos::gArea
rgeos::gIntersection
. Last email 26 July: "this is a little update on the situation of the package LabourMarketAreas w.r.t. spatial packages. We have updated the package but, before uploading it to Cran, we would like to update the vignette as well. This will be done after the holydays. I will let you know as soon as the upload has been finalised."In addition, Iñaki would like 2.1-0 on CRAN (well) before 3 October, "I believe there's margin to land sp 2.1 in the final freeze (Oct 3)" (for F39). Then F39 will have sp released from
rgdal
etc., and will drop retiring packages.R-universe r-universe-org/help#286 (comment) should be OK, but I'll declare specific dates when we know them.
Debian will be problematic, but there isn't too much we can do about that: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1049438
I've also added
GridsDatums
tosp/data
to keep it around whenrgdal
is gone.