Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trap NULL projargs #74

Merged
merged 2 commits into from
Feb 25, 2020
Merged

trap NULL projargs #74

merged 2 commits into from
Feb 25, 2020

Conversation

rsbivand
Copy link
Contributor

addresses #73

@edzer
Copy link
Owner

edzer commented Feb 25, 2020

This doesn't solve the problem that caused a NULL to be passed to CRS() in the first place. Shouldn't a NULL break CRS()?

@rsbivand
Copy link
Contributor Author

Maybe a warning if input argument is NULL?

@edzer
Copy link
Owner

edzer commented Feb 25, 2020

Good idea.

@rsbivand
Copy link
Contributor Author

Now:

> r <- raster(pols, res = 1)
Warning message:
In CRS(attr(x[[attr(x, "sf_column")]], "crs")[["proj4string"]]) :
  CRS: projargs should not be NULL; set to NA

@edzer edzer merged commit 86fb8e3 into edzer:master Feb 25, 2020
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Jul 23, 2020
Update to 1.4.2
6e8e9e7 
Upstream changes:
Changes in version 1.4-1 (2020-xx-yy)

    warn on NULL projargs in CRS(); edzer/sp#74

Changes in version 1.4-0 (2020-02-21)

    prepare for new (>= 1.5.1) rgdal, which creates and listens to a comments() field of a CRS object carrying a WKT representation of a CRS rather than the proj4string; @rsb, edzer/sp#67 and edzer/sp#69 ; for more info see e.g. edzer/sp#68 and r-spatial/discuss#28

Changes in version 1.3-2 (2019-11-07)

    fix length > 1 in coercion to logical error; #54, #60

    add is.na method for CRS objects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rsbivand @edzer