Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #92 #93

Merged
merged 1 commit into from
Nov 27, 2020
Merged

fix #92 #93

merged 1 commit into from
Nov 27, 2020

Conversation

bastistician
Copy link
Contributor

spp is "SpatialPoints", so the proj4string argument is ignored anyway
(and produces a warning since 9101ce2)

`spp` is "SpatialPoints", so the proj4string argument is ignored anyway
(and produces a warning since 9101ce2)
@bastistician
Copy link
Contributor Author

@edzer: Is there anything I can do to amplify this PR? It will fix #92.

With current sp, I'm getting a whole bunch of these warnings

  If the coords argument is a SpatialPoints object, set its CRS first;
  the proj4string argument to this function is ignored.

from calling spplot in surveillance.

@edzer
Copy link
Owner

edzer commented Nov 27, 2020

I see this is caused by (indirect) contribution from @finnlindgren. If surveillance would have used this in a package test, reverse dependency checks should have caught it before release.

@edzer edzer merged commit 080a9e9 into edzer:master Nov 27, 2020
@bastistician
Copy link
Contributor Author

Unfortunately not. Warnings from running tests and examples are currently not raised to the R CMD check log.
This is why I let my local "make check" rule additionally grep the generated -Ex.Rout file for "^Warning" (see HenrikBengtsson/Wishlist-for-R#83).

BTW, in released sp 1.4-4 itself, the example(spplot, ask=FALSE) also produces the above warning.
I see quiet a few other warnings in sp-Ex.Rout, but I haven't checked whether they are expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants