[refs #89212] Update product permissions

eea · Oct 20, 2017 · bd88336 · bd88336
1 parent d872d43
commit bd88336
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/insitu/templates/product/detail.html b/insitu/templates/product/detail.html
@@ -14,7 +14,7 @@
   <div class="row">
     <h1 class="col-sm-12">
       <span>Product details</span>
-      {% if request.user.service_resp or request.user.is_superuser %}
+      {% if request.user.is_superuser %}
         <span class="pull-right delete-btn">
         <a class="btn btn-primary pull-right"
            href="{% url 'product:delete' product.pk %}">Delete
@@ -108,7 +108,7 @@ <h1 class="col-sm-12">
   <div class="row">
     <h3 class="col-sm-12">
       <span>Requirements</span>
-      {% if request.user.service_resp or request.user.is_superuser %}
+      {% if request.user.is_superuser %}
         <span class="pull-right">
           <a class="btn btn-primary pull-right"
              href="{% url 'product:requirement:add' product.pk %}">Add requirement</a>
@@ -126,7 +126,7 @@ <h3 class="col-sm-12">
           <th>Criticality</th>
           <th class="no-sort">Barriers</th>
           <th class="no-sort">Note</th>
-          {% if request.user.service_resp or request.user.is_superuser %}
+          {% if request.user.is_superuser %}
             <th class="no-sort"></th>
           {% endif %}
         </tr>

diff --git a/insitu/templates/product/list.html b/insitu/templates/product/list.html
@@ -15,7 +15,7 @@
   <div class="row">
     <h1 class="col-sm-12">
       <span>Products</span>
-      {% if request.user.service_resp or request.user.is_superuser %}
+      {% if request.user.is_superuser %}
         <span class="pull-right">
         <a class="btn btn-primary pull-right"
            href="{% url 'product:add' %}">New product</a>

diff --git a/insitu/tests/test_product.py b/insitu/tests/test_product.py
@@ -19,8 +19,7 @@ def setUp(self):
         status = base.ProductStatusFactory()
         coverage = base.CoverageFactory()
 
-        responsible_user = base.UserFactory()
-        base.CopernicususResponsibleFactory(user=responsible_user)
+        responsible_user = base.UserFactory(is_superuser=True)
         self.client.force_login(responsible_user)
         self._DATA = {
             'acronym': 'TST',

diff --git a/insitu/views/product.py b/insitu/views/product.py
@@ -14,6 +14,7 @@
 from insitu.views.protected.permissions import (
     IsAuthenticated,
     IsCopernicusServiceResponsible,
+    IsSuperuser
 )
 from picklists import models as pickmodels
 
@@ -74,7 +75,7 @@ def get(self, request, *args, **kwargs):
 class ProductAdd(ProtectedCreateView):
     template_name = 'product/add.html'
     form_class = forms.ProductForm
-    permission_classes = (IsCopernicusServiceResponsible, )
+    permission_classes = (IsSuperuser, )
 
     def permission_denied(self, request):
         self.permission_denied_redirect = reverse('product:list')
@@ -91,7 +92,7 @@ class ProductEdit(ProtectedUpdateView):
     form_class = forms.ProductForm
     model = models.Product
     context_object_name = 'product'
-    permission_classes = (IsCopernicusServiceResponsible, )
+    permission_classes = (IsSuperuser, )
 
     def permission_denied(self, request):
         self.permission_denied_redirect = reverse('product:list')
@@ -119,7 +120,7 @@ class ProductDelete(ProtectedDeleteView):
     form_class = forms.ProductForm
     model = models.Product
     context_object_name = 'product'
-    permission_classes = (IsCopernicusServiceResponsible, )
+    permission_classes = (IsSuperuser, )
 
     def permission_denied(self, request):
         self.permission_denied_redirect = reverse('product:list')