Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

202 gs purge criterion #205

Merged
merged 10 commits into from
Sep 2, 2020
Merged

Conversation

gbastien
Copy link
Contributor

This also include #204 fix...

Will adapt things before merge.

Thank you,

Gauthier

@avoinea avoinea changed the base branch from master to develop August 31, 2020 11:11
@avoinea
Copy link
Member

avoinea commented Sep 1, 2020

@gbastien Thank you!

Can you please rebase this PR branch on eea:develop to make the tests pass.

@gbastien
Copy link
Contributor Author

gbastien commented Sep 1, 2020

Hi @avoinea done, could you please review and merge?
Thank you!
Gauthier

@avoinea
Copy link
Member

avoinea commented Sep 1, 2020

@gbastien I don't see the xml where do you purge at criterion level. Do I miss something?

…lse" at criteria level as it is purge="True" by default
@gbastien
Copy link
Contributor Author

gbastien commented Sep 2, 2020

Hi @avoinea

I fixed the test, I was disturbed during write of this test by doctests never failing ;-)

This time this should be done, to use "purge" at level, purge="False" must be set at level as it is purge="True" by default.

Gauthier

@gbastien
Copy link
Contributor Author

gbastien commented Sep 2, 2020

@avoinea Great!

I would like to propose another PR regarding #207 so feel free to make a new release when you want or not ;-)

Gauthier

@gbastien
Copy link
Contributor Author

gbastien commented Sep 4, 2020

Hi @avoinea

finally as #207 will take a bit longer than expected, I think we can go on discussing it and precising the use case but we have urgent work to do on another thing for now.

So if you could do a new release that would be great ;-)

Thank you!

Gauthier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants