Refactor local settings #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuliachiriac
commented
Apr 20, 2017
settings.env.example
Outdated
| AUTH_LDAP_START_TLS=True | ||
| AUTH_LDAP_USER_FIRST_NAME=givenName | ||
| AUTH_LDAP_USER_LAST_NAME=sn | ||
| AUTH_LDAP_USER_EMAIL=mail |
There was a problem hiding this comment.
We can consider these four variables (AUTH_LDAP_START_TLS, AUTH_LDAP_USER_FIRST_NAME, AUTH_LDAP_USER_LAST_NAME, AUTH_LDAP_USER_EMAIL) constants (they don't need to be modified for each installation). The other two (AUTH_LDAP_SERVER_URI and AUTH_LDAP_USER_DN_TEMPLATE) you should be fetched from the environment.
dianaboiangiu
force-pushed
the
refactor_local_settings
branch
from
34ba259
to
b81c3dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.