Skip to content

Commit

Permalink
fix: i18n - Fix untranslated text persent in addon
Browse files Browse the repository at this point in the history
  • Loading branch information
iFlameing committed Aug 17, 2023
1 parent f5852d9 commit e624d9b
Show file tree
Hide file tree
Showing 8 changed files with 104 additions and 20 deletions.
15 changes: 15 additions & 0 deletions locales/de/LC_MESSAGES/volto.po
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@ msgstr "Akkordeon"
msgid "Accordion Title size"
msgstr "Akkordeon Schriftgröße Titel"

#: components/manage/Blocks/Accordion/Schema
# defaultMessage: Accordion block
msgid "Accordion block"
msgstr "Akkordeon Block"

#: components/manage/Blocks/Accordion/Schema
# defaultMessage: Accordion theme
msgid "Accordion theme"
Expand All @@ -46,11 +51,21 @@ msgstr "Erlaube mehrere Panele zur gleichen Zeit geöffnet zu haben"
msgid "Collapsed by default"
msgstr "Eingeklappt ist der Standard"

#: components/manage/Blocks/Accordion/Schema
# defaultMessage: Enable filtering
msgid "Enable filtering"
msgstr ""

#: components/manage/Blocks/Accordion/Schema
# defaultMessage: Friendly name
msgid "Friendly name"
msgstr "Kurzname"

#: components/manage/Blocks/Accordion/Schema
# defaultMessage: Headline
msgid "Headline"
msgstr ""

#: components/manage/Blocks/Accordion/Schema
# defaultMessage: Non exclusive
msgid "Non exclusive"
Expand Down
15 changes: 15 additions & 0 deletions locales/it/LC_MESSAGES/volto.po
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@ msgstr "Accordion"
msgid "Accordion Title size"
msgstr "Dimensione del titolo"

#: components/manage/Blocks/Accordion/Schema
# defaultMessage: Accordion block
msgid "Accordion block"
msgstr ""

#: components/manage/Blocks/Accordion/Schema
# defaultMessage: Accordion theme
msgid "Accordion theme"
Expand All @@ -46,11 +51,21 @@ msgstr "Consente di avere più pannelli aperti contemporaneamente"
msgid "Collapsed by default"
msgstr "Collassati di default"

#: components/manage/Blocks/Accordion/Schema
# defaultMessage: Enable filtering
msgid "Enable filtering"
msgstr ""

#: components/manage/Blocks/Accordion/Schema
# defaultMessage: Friendly name
msgid "Friendly name"
msgstr "Titolo dell'elemento"

#: components/manage/Blocks/Accordion/Schema
# defaultMessage: Headline
msgid "Headline"
msgstr ""

#: components/manage/Blocks/Accordion/Schema
# defaultMessage: Non exclusive
msgid "Non exclusive"
Expand Down
15 changes: 15 additions & 0 deletions locales/pt_BR/volto.po
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@ msgstr "Acordeão"
msgid "Accordion Title size"
msgstr "Tamanho do título do Acordeão"

#: components/manage/Blocks/Accordion/Schema
# defaultMessage: Accordion block
msgid "Accordion block"
msgstr ""

#: components/manage/Blocks/Accordion/Schema
# defaultMessage: Accordion theme
msgid "Accordion theme"
Expand All @@ -46,11 +51,21 @@ msgstr "Permitir muitos painéis abertos ao mesmo tempo"
msgid "Collapsed by default"
msgstr "Por padrão fechado"

#: components/manage/Blocks/Accordion/Schema
# defaultMessage: Enable filtering
msgid "Enable filtering"
msgstr ""

#: components/manage/Blocks/Accordion/Schema
# defaultMessage: Friendly name
msgid "Friendly name"
msgstr "Nome amigável"

#: components/manage/Blocks/Accordion/Schema
# defaultMessage: Headline
msgid "Headline"
msgstr ""

#: components/manage/Blocks/Accordion/Schema
# defaultMessage: Non exclusive
msgid "Non exclusive"
Expand Down
15 changes: 15 additions & 0 deletions locales/ro/LC_MESSAGES/volto.po
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,11 @@ msgstr "Acordeon"
msgid "Accordion Title size"
msgstr "Mărimea titlului acordeonului"

#: components/manage/Blocks/Accordion/Schema
# defaultMessage: Accordion block
msgid "Accordion block"
msgstr ""

#: components/manage/Blocks/Accordion/Schema
# defaultMessage: Accordion theme
msgid "Accordion theme"
Expand All @@ -41,11 +46,21 @@ msgstr "Permite deschiderea mai multor panouri simultan"
msgid "Collapsed by default"
msgstr "Închis implicit"

#: components/manage/Blocks/Accordion/Schema
# defaultMessage: Enable filtering
msgid "Enable filtering"
msgstr ""

#: components/manage/Blocks/Accordion/Schema
# defaultMessage: Friendly name
msgid "Friendly name"
msgstr "Nume"

#: components/manage/Blocks/Accordion/Schema
# defaultMessage: Headline
msgid "Headline"
msgstr ""

#: components/manage/Blocks/Accordion/Schema
# defaultMessage: Non exclusive
msgid "Non exclusive"
Expand Down
17 changes: 16 additions & 1 deletion locales/volto.pot
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
msgid ""
msgstr ""
"Project-Id-Version: Plone\n"
"POT-Creation-Date: 2022-09-27T08:42:53.695Z\n"
"POT-Creation-Date: 2023-08-17T14:38:07.278Z\n"
"Last-Translator: Plone i18n <plone-i18n@lists.sourceforge.net>\n"
"Language-Team: Plone i18n <plone-i18n@lists.sourceforge.net>\n"
"MIME-Version: 1.0\n"
Expand All @@ -23,6 +23,11 @@ msgstr ""
msgid "Accordion Title size"
msgstr ""

#: components/manage/Blocks/Accordion/Schema
# defaultMessage: Accordion block
msgid "Accordion block"
msgstr ""

#: components/manage/Blocks/Accordion/Schema
# defaultMessage: Accordion theme
msgid "Accordion theme"
Expand All @@ -43,11 +48,21 @@ msgstr ""
msgid "Collapsed by default"
msgstr ""

#: components/manage/Blocks/Accordion/Schema
# defaultMessage: Enable filtering
msgid "Enable filtering"
msgstr ""

#: components/manage/Blocks/Accordion/Schema
# defaultMessage: Friendly name
msgid "Friendly name"
msgstr ""

#: components/manage/Blocks/Accordion/Schema
# defaultMessage: Headline
msgid "Headline"
msgstr ""

#: components/manage/Blocks/Accordion/Schema
# defaultMessage: Non exclusive
msgid "Non exclusive"
Expand Down
6 changes: 4 additions & 2 deletions src/components/manage/Blocks/Accordion/Edit.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,8 @@ const Edit = (props) => {
? pickBy(blocksConfig, (value, key) => allowedBlocks.includes(key))
: blocksConfig;

const schema = AccordionBlockSchema({ intl });

return (
<>
{data.headline && <h2 className="headline">{data.headline}</h2>}
Expand Down Expand Up @@ -428,8 +430,8 @@ const Edit = (props) => {
)}
{!data?.readOnlySettings && (
<BlockDataForm
schema={AccordionBlockSchema({ intl })}
title="Accordion block"
schema={schema}
title={schema.title}
onChangeField={(id, value) => {
onChangeBlock(block, {
...data,
Expand Down
38 changes: 22 additions & 16 deletions src/components/manage/Blocks/Accordion/Schema.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ const messages = defineMessages({
id: 'Accordion',
defaultMessage: 'Accordion',
},
AccordionBlock: {
id: 'Accordion block',
defaultMessage: 'Accordion block',
},
Options: {
id: 'Options',
defaultMessage: 'Options',
Expand Down Expand Up @@ -73,25 +77,27 @@ const messages = defineMessages({
},
});

export const AccordionSchema = {
title: 'Accordion',
fieldsets: [
{
id: 'default',
title: 'Default',
fields: ['panel_title'],
},
],
properties: {
panel_title: {
title: 'Accordion title',
export const AccordionSchema = (intl) => {
return {
title: intl.formatMessage(messages.Accordion),
fieldsets: [
{
id: 'default',
title: 'Default',
fields: ['panel_title'],
},
],
properties: {
panel_title: {
title: 'Accordion title',
},
},
},
required: [],
required: [],
};
};

export const AccordionBlockSchema = ({ intl }) => ({
title: 'Accordion block',
title: intl.formatMessage(messages.AccordionBlock),
fieldsets: [
{
id: 'default',
Expand Down Expand Up @@ -124,7 +130,7 @@ export const AccordionBlockSchema = ({ intl }) => ({
data: {
title: intl.formatMessage(messages.Accordion),
type: 'panels',
schema: AccordionSchema,
schema: AccordionSchema(intl),
},
title_size: {
title: intl.formatMessage(messages.title_size),
Expand Down
3 changes: 2 additions & 1 deletion src/components/manage/Widgets/PanelsWidget.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ const PanelsWidget = (props) => {
<Icon name={addSVG} size="18px" />
&nbsp;
{/* Custom addMessage in schema, else default to english */}
{objectSchema.addMessage || `Add ${objectSchema.title}`}
{objectSchema.addMessage ||
`${intl.formatMessage(messages.add)} ${objectSchema.title}`}
</Button>
</div>
</FormFieldWrapper>
Expand Down

0 comments on commit e624d9b

Please sign in to comment.