Skip to content

Commit

Permalink
Simplify a bit
Browse files Browse the repository at this point in the history
  • Loading branch information
tiberiuichim committed Oct 10, 2020
1 parent bce150c commit 243b415
Showing 1 changed file with 17 additions and 10 deletions.
27 changes: 17 additions & 10 deletions src/ColumnsBlock/ColumnsBlockEdit.jsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React from 'react';
import { Grid, Segment } from 'semantic-ui-react';
import { isEmpty, clone } from 'lodash';
import { isEmpty } from 'lodash';
import { SidebarPortal, Icon } from '@plone/volto/components'; // BlocksForm, Icon,
import InlineForm from '@plone/volto/components/manage/Form/InlineForm';
import { emptyBlocksForm } from '@eeacms/volto-blocks-form/helpers';
Expand Down Expand Up @@ -151,23 +151,30 @@ class ColumnsBlockEdit extends React.Component {
);
const variant = available_variants?.[0];
if (variant) {
this.props.onChangeBlock(this.props.block, {
return this.props.onChangeBlock(this.props.block, {
...this.props.data,
gridCols: variant.defaultData.gridCols,
});
}
}

const { block, onChangeBlock, data } = this.props;

// fill empty columns
if (hasColumns(this.props.data.data)) {
forEachColumn(this.props.data.data, ([colId, colData]) => {
if (hasColumns(data.data)) {
forEachColumn(data.data, ([colId, colData]) => {
if (columnIsEmpty(colData)) {
const newCol = defaultNewColumn();
const fd = clone(this.props.properties);
fd.blocks[this.props.block].data.blocks[colId] = newCol;

this.props.onChangeField('blocks', fd.blocks);
this.props.onChangeField('blocks_layout', fd.blocks_layout);
const newData = {
...data,
data: {
...data.data,
blocks: {
...data.data.blocks,
[colId]: defaultNewColumn(),
},
},
};
onChangeBlock(block, newData);
}
});
}
Expand Down

0 comments on commit 243b415

Please sign in to comment.