refactor(PublicationCard):remove link wrapper

eea · Mar 17, 2022 · 5911a0d · 5911a0d
1 parent 81a5bfc
commit 5911a0d
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 22 deletions.
diff --git a/src/ui/PublicationCard/PublicationCard.jsx b/src/ui/PublicationCard/PublicationCard.jsx
@@ -1,11 +1,7 @@
 import React from 'react';
 
 function PublicationCard({ children, ...rest }) {
-  return (
-    <div className="eea publication card">
-      <a href={rest.href}>{children}</a>
-    </div>
-  );
+  return <div className="eea publication card">{children}</div>;
 }
 
 PublicationCard.Header = ({ children, ...rest }) => (

diff --git a/src/ui/PublicationCard/PublicationCard.stories.jsx b/src/ui/PublicationCard/PublicationCard.stories.jsx
@@ -23,13 +23,6 @@ export default {
         defaultValue: { summary: '' },
       },
     },
-    href: {
-      description: 'publication link url',
-      table: {
-        type: { summary: 'string' },
-        defaultValue: { summary: '' },
-      },
-    },
   },
 };
 
@@ -50,15 +43,13 @@ Default.args = {
   tag: 'Publication',
   description:
     'Leo fermentum sollicitudin suspendisse iaculis feugiat. Eget tellus blandit aenean mattis.',
-  href: '/#',
 };
 
 export const DefaultWithLongDescription = Template.bind({});
 DefaultWithLongDescription.args = {
   tag: 'Publication',
   description:
     'Leo fermentum sollicitudin suspendisse iaculis feugiat. Eget tellus blandit aenean mattis. Leo fermentum sollicitudin suspendisse iaculis feugiat. Eget tellus blandit aenean mattis. Leo fermentum sollicitudin suspendisse iaculis feugiat. Eget tellus blandit aenean mattis. Eget tellus blandit aenean mattis. Leo fermentum sollicitudin suspendisse iaculis feugiat. Eget tellus blandit aenean mattis. ',
-  href: '/#',
 };
 
 export const PublicationCardWithImage = Template.bind({});
@@ -67,7 +58,6 @@ PublicationCardWithImage.args = {
   description:
     'Leo fermentum sollicitudin suspendisse iaculis feugiat. Eget tellus blandit aenean mattis.',
   image: true,
-  href: '/#',
 };
 PublicationCardWithImage.argTypes = {
   image: {

diff --git a/theme/themes/eea/extras/publicationCard.less b/theme/themes/eea/extras/publicationCard.less
@@ -17,13 +17,6 @@
     flex-direction: column;
     justify-content: space-between;
 
-    a {
-        display: contents;
-        text-decoration: none;
-        color: @publicationCardtextColor;
-        cursor: pointer;
-    }
-
     .header{
         background-repeat: no-repeat;
         background-position: center;