Skip to content

Commit

Permalink
fix(buttons): border set on basic buttons appearing on svg elements o…
Browse files Browse the repository at this point in the history
…f Volto UI

- Removed also basicBoxShadow set at transparent by Volto
  • Loading branch information
ichim-david committed Apr 4, 2022
1 parent 4b6ab67 commit 69ca73f
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 12 deletions.
24 changes: 13 additions & 11 deletions theme/themes/eea/elements/button.overrides
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,19 @@
}

/* Global Button Styles */
.ui.button,
.ui.buttons .button,
.ui.buttons {
border: @buttonBorder @backgroundColor;

&:hover,
&:active,
&:focus {
border-color: @hoverBackgroundColor;
}
}
// 147629 to remove later, basic buttons don't need borders, svg buttons are
// basic and volto ui has elements that are highlighted because of it
//.ui.button,
//.ui.buttons .button,
//.ui.buttons {
// border: @buttonBorder @backgroundColor;
//
// &:hover,
// &:active,
// &:focus {
// border-color: @hoverBackgroundColor;
// }
//}

/* Primary Button Border */
.ui.button.primary,
Expand Down
2 changes: 1 addition & 1 deletion theme/themes/eea/elements/button.variables
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@
@basicBackground: transparent none;
@basicFontWeight: @normal;
@basicBorder: 1px solid @borderColor;
@basicBoxShadow: 0px 0px 0px @basicBorderSize @textColor inset;
@basicBoxShadow: none; // remove basic box shadow by default
@basicLoadingColor: @offWhite;
@basicTextTransform: none;

Expand Down

0 comments on commit 69ca73f

Please sign in to comment.