Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update components to use token values #289

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

tarantilis
Copy link
Collaborator

@tarantilis tarantilis commented Feb 1, 2023

https://taskman.eionet.europa.eu/issues/160247

All the border colors that had hex number or a color token are replaced.
https://62713c57bcbdf4004a3d99b8-ubqdlqnylz.chromatic.com/

Some things to discuss before merging to finalize borders:

  • There are still a lot of semantic border color tokens in site.variables, if we want them removed now is the time (@strongBorderColor, @internalBorderColor, etc.). Some of them are used a lot in the code, mostly for things that we didn't need to override (@solidBorderColor) so deleting them all might be time consuming.
  • Many components have custom rbga colors assign to their own border color tokens. (input.variables, button box shadows, etc.) If we need them gone, I should create a full list and ask the ux team.
  • We have to create a white variable or override the (@whiteBorderColor: rgba(255, 255, 255, 0.1); We have white borders in the design (header menu items).
  • For the checkbox border (main.variables in extras) the design team prefers if we don't assign the primary border color token, I left them as they were for now for you to check

PS: Latest commit: refactor(Borders): Update segment and label is separated because I took the liberty to assign the background color of the label to the border and changed the semantic dash border of the segment to a bit different token

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

👋 @tarantilis

To generate the Storybook and Docusaurus websites, write comment with:

@eea-jenkins build all

To generate only Storybook write comment with:

@eea-jenkins build storybook

To generate only Docusaurus write comment with:

@eea-jenkins build docusaurus

@tarantilis
Copy link
Collaborator Author

@eea-jenkins build storybook

@jenkins-ci-eionet-europa-eu
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants