Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change(carousel): responsive design improvements for carousel template #49

Merged
merged 2 commits into from
Feb 28, 2023
Merged

change(carousel): responsive design improvements for carousel template #49

merged 2 commits into from
Feb 28, 2023

Conversation

ichim-david
Copy link
Member

  • set only 2 cards for 767px and lower until we react mobile resolution as 3 cards would be too small
  • set value of slidesToScroll to the same value of slidesToShow, this way the algorithm is better at scrolling the cards in view
  • set initialSlide to 0 to better calculate the infinite scroll of the cards

@ichim-david
change(carousel): responsive design improvements for carousel template
adb9e21 
- set only 2 cards for 767px and lower until we react mobile resolution as 3
  cards would be too small
- set value of slidesToScroll to the same value of slidesToShow, this way the
  algorithm is better at scrolling the cards in view
- set initialSlide to 0 to better calculate the infinite scroll of the cards
@avoinea avoinea merged commit 0224078 into master Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avoinea avoinea avoinea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ichim-david @avoinea