feat(card): add object-fit and object-position properties in image refs #250422 #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoinea
requested changes
Apr 12, 2023
src/blocks/Listing/schema.js
Outdated
| @@ -282,6 +284,28 @@ export const setCardStylingSchema = ({ schema, intl }) => { | |||
| actions: Object.keys(ALIGN_INFO_MAP), | |||
| actionsInfoMap: ALIGN_INFO_MAP, | |||
| }, | |||
| objectfit: { | |||
There was a problem hiding this comment.
@nileshgulia1 You should use either camelCase or snake_case for 2-words properties names.
There was a problem hiding this comment.
@avoinea As those fields are used as css classes yield by styleWrapper, I don't think we have a notion to use cameCase CSS in design system. Maybe we can use ['object-fit'] ?
ichim-david
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.