Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jekyll site does not build if not GitHub repo #29

Closed
seshrs opened this issue Dec 11, 2019 · 0 comments · Fixed by #26
Closed

Jekyll site does not build if not GitHub repo #29

seshrs opened this issue Dec 11, 2019 · 0 comments · Fixed by #26
Assignees
@seshrs
Labels
bug Something isn't working
Milestone
SP/SU 2020

Comments

@seshrs
Copy link
Member

seshrs commented Dec 11, 2019

While going through the setup instructions with @oliverdmiles, we encountered an issue where the Jekyll site would not build if the directory was not a GitHub repository.

@oliverdmiles also discovered the fix, which I believe involved updating the Gemfile with some additional dependencies. The Usage instructions need to be updated to address this issue.
@seshrs seshrs added the bug Something isn't working label Dec 11, 2019
@seshrs seshrs added this to the SP/SU 2020 milestone Dec 11, 2019
@seshrs seshrs self-assigned this Dec 11, 2019
seshrs added a commit that referenced this issue Dec 15, 2019
@seshrs
Refocus README on Jekyll Usage
2869aea 
Since we recommend most users to use Primer Spec with Jekyll, this commit moves the plugin-related instructions to the 'advanced usage' doc.
This commit also includes a change to the suggested Gemfile code to resolve #29.
@seshrs seshrs mentioned this issue Dec 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seshrs seshrs

Labels
bug Something isn't working
Projects
None yet
Milestone
SP/SU 2020
Development

Successfully merging a pull request may close this issue.

[Docs] Update demo to be a meta project spec! eecs485staff/primer-spec
1 participant
@seshrs