Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow omitting Dispatch client code #322

Closed
wants to merge 2 commits into from
Closed

Allow omitting Dispatch client code #322

wants to merge 2 commits into from

Conversation

liff
Copy link

@liff liff commented May 6, 2015

Adds a flag and relevant settings for disabling generation of Dispatch client code.

Sometimes we may want to use our own HTTP client without bringing in an unused Dispatch dependency.

Olli Helenius added 2 commits May 6, 2015 13:34
This allows us to add more fields to it. At the moment adding just one takes it over the 22 field limit.
Adds:
  --no-dispatch-client – command line parameter
  enableDispatchClient – SBT setting
  scalaxb.enableDispatchClient – Maven setting

The default value is ‘true’ so that current behavior is not changed.
@eed3si9n
Copy link
Owner

Sorry I haven't commented on this PR yet.
I was thinking maybe having Seq of sealed trait is a better way of representing config. I have to experiment and see how it would look.

eed3si9n pushed a commit that referenced this pull request Jul 20, 2015
@eed3si9n
Copy link
Owner

Closing this in favor of #345

@eed3si9n eed3si9n closed this Jul 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants