Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for http4s 0.22.x client generation - httpclients_http4s_0_22.scala.template #601

Merged
merged 1 commit into from Mar 12, 2023

Conversation

kevin-lee
Copy link
Contributor

Add support for http4s 0.22.x client generation - httpclients_http4s_0_22.scala.template

I have to use http4s 0.22.15, but scalaxb's http4s client generation seems to support only 0.21 and 0.23.
I've tested it locally with publishLocal, and it works fine. I hope this PR is approved.

Please let me know if I missed anything or need to do anything else.

Copy link
Owner

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @kevin-lee!

@eed3si9n
Copy link
Owner

eed3si9n commented Mar 8, 2023

I am not really familiar with http4s, but do they have to be different for each releases? In other words, can 0.22+ use the same code? /cc @zarthross

@kevin-lee
Copy link
Contributor Author

I am not really familiar with http4s, but do they have to be different for each releases? In other words, can 0.22+ use the same code? /cc @zarthross

@eed3si9n http4s 0.21 and 0.22 use cats-effect 2, whereas 0.23 uses cats-effect 3.
The template for 0.23 seems compatible with 0.22, but there can be some issues.

  1. If any cats-effect 3 specific types are added to the template for 0.23 in the future, it will break the 0.22 one.
  2. 0.22 has breaking changes from 0.21, so the template is incompatible.

@kevin-lee
Copy link
Contributor Author

I don't want to add more maintenance cost to scalaxb, so if this is merged and there's any issue with that template I've added in the future, please let me know. I'll be more than happy to fix it.

@kevin-lee
Copy link
Contributor Author

Thanks for your approval @eed3si9n. It would be good to have @zarthross's feedback as well.

@eed3si9n eed3si9n merged commit 90b6d8a into eed3si9n:develop Mar 12, 2023
@kevin-lee kevin-lee deleted the add-http4s-0.22-support branch March 13, 2023 03:24
@kevin-lee
Copy link
Contributor Author

Thanks, @zarthross, for http4s client support. The real credit for this PR should be all yours, as the template is the same as yours except for removing unused imports. I still had to put the template due to the reason I mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants