Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support choosing javax or jakarta for jaxb package name #613

Merged
merged 1 commit into from Oct 4, 2023

Conversation

mrdziuban
Copy link
Contributor

For users who want to use jaxb-api versions >= 3. The default is still javax but can be changed to jakarta via the CLI by passing

--jaxb-package jakarta

And via the SBT plugging by setting

scalaxbJaxbPackage := JaxbPackage.Jakarta

@@ -51,6 +51,7 @@ object ScalaxbPlugin extends sbt.AutoPlugin {
scalaxbEnumNameMaxLength := 50,
scalaxbUseLists := false,
scalaxbAsync := true,
scalaxbJaxbPackage := JaxbPackage.Javax,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default should be Jakarta?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I chose to keep the default javax so that this isn't a breaking change

Copy link
Owner

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eed3si9n eed3si9n merged commit eadcf3e into eed3si9n:develop Oct 4, 2023
1 check passed
@mrdziuban mrdziuban deleted the customize-jaxb-package branch October 4, 2023 18:17
@zarthross
Copy link
Contributor

@eed3si9n, we are trying to update our Jakarta version and it would be awesome if we could use this change for that, can you make a release for this soon?

@eed3si9n
Copy link
Owner

eed3si9n commented Dec 2, 2023

https://scalaxb.org/scalaxb-1.12.0 is out!

@zarthross
Copy link
Contributor

@eed3si9n Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants