-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to reconciliation API authority connector #204
base: master
Are you sure you want to change the base?
Conversation
Sounds nice! Just some suggestions with an eye toward a cleaner PR, if it's not too much trouble:
|
Cool, I will try to do as you say. I am not particularly experienced with rebasing, reverting and such, so I hope I'll not botch up everything. Thanks for looking into it! |
This reverts commit f62ac8e.
Is there any further action required on my part or are things taking their course? I don't mean to rush, just want to make sure things are not waiting for something to happen on my end. |
Looks great. My only worry is that you reformatted Did you change a lot in those two files? |
:eek: 😱 Sorry, I did not mean to do the reformatting (probably it was an automatic pretty-printing at some point). I'll try and see if I can roll this back! Also, I think it will be good if I check the conflicts in the corresponding tei-publisher-components pull request (eeditiones/tei-publisher-components#168), for the two pull requests kind of need to go hand in hand. And while I'm there, I might also have a look at the So there is in fact things that have to happen on my end 😉 |
@ref
and@key