Fix/16+ check ci results #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix repo url close #15
duncdrum
force-pushed
the
fix/16+
branch
2 times, most recently
from
4ec4ec7
to
af5da9f
Compare
some typos
This was referenced Jul 27, 2023
line-o
reviewed
Aug 2, 2023
| @@ -4,7 +4,7 @@ | |||
| name="http://e-editiones.org/tuttle" | |||
| abbrev="tuttle" version="1.2.0" spec="1.0"> | |||
| <title>Tuttle - Git for eXist-db</title> | |||
| <dependency processor="http://exist-db.org" semver-min="5.3.0"/> | |||
| <dependency processor="http://exist-db.org" semver-min="5.5.1"/> | |||
There was a problem hiding this comment.
Changing the minimum required processor version is a breaking change. Are you certain this is necessary?
There was a problem hiding this comment.
Based on the principle that this is the earliest version I m willing to support yes. Does it run on earlier versions maybe…
There was a problem hiding this comment.
also that's why it says BREAKING CHANGES in the op ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #17
Note: tests on
7.0.0-SNAPSHOTare failingBREAKING CHANGES