Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buffer allocation in pipe for Mac OS X #47

Merged
merged 2 commits into from
Dec 22, 2014

Conversation

djMax
Copy link
Contributor

@djMax djMax commented Nov 28, 2014

Fixes Issue #46 and suppresses a warning for unused function.

@eelcocramer
Copy link
Owner

Hi, I've created a new branch called issue47 but also changes the type of the result buffer to unsigned char. It compiles on OSX but I cannot verify if this branch still fixes your issue. Could you try this branch before I merge and publish a new version?

Before I publish I also need to verify the code on Linux as my changes also hits the linux source tree.

@djMax
Copy link
Contributor Author

djMax commented Dec 11, 2014

I can verify that the new branch works on OSX and fixes the issue as well. I'll be trying this on linux in a bit.

@eelcocramer
Copy link
Owner

Thanks for testing!

@djMax
Copy link
Contributor Author

djMax commented Dec 15, 2014

Linux appears to be fine as well, though Bluetooth in general there is a complete pain in the arse. (Raspberry Pi)

@eelcocramer
Copy link
Owner

:-)

I'll check and merge this after the weekend on Monday or Tuesday.

@eelcocramer eelcocramer merged commit 1ec4073 into eelcocramer:master Dec 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants