Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speexdsp component is set in fixed-point not agree with the top level API #2

Closed
Kaipingli88 opened this issue Aug 16, 2022 · 3 comments
Assignees

Comments

@Kaipingli88
Copy link
Contributor

The speexdsp component supports both floating-point and fixed-point implementations. It is set to fixed-point but the top level API is for floating-point (f32) implementation with fixed-point audio inputs. In the speexdsp component, change to floating-point by modify config.h file as shown below. It compiles but it does not run properly.
/* Compile as fixed-point */
//#define FIXED_POINT 1

/* Compile as floating-point */
#define FLOATING_POINT /**//

@llefaucheur
Copy link
Contributor

You are true. I will revert it to float32.
I will check if float16 is feasible, since the resolution/accuracy it is very appropriate for this family of algorithms.
Let's anticipate the acceptance criterion, much must not based on bit-exactness.

@petertorelli
Copy link
Member

I can compile FIXED_POINT and run, but FLOATING_POINT segfaults. Working on this now.

@petertorelli
Copy link
Member

When using FLOATING_POINT here is the status of my testing

  • USE_SMALLFT - Ok
  • USE_INTEL_MKL - I don't have the MKL, couldn't test
  • USE_INTEL_IPP - Ditto but for IPP
  • USE_GPL_FFTW3 - Ditto for FFTW3
  • USE_KISS_FFT - Broken, cannot be used with FLOATING_POINT or FIXED_POINT defined, but one must be defined.

Not sure why I'm no longer getting a segmentation fault that I saw yesterday.

See PR #8. Since I'm not using HAVE_CONFIG_H, all SpeeX config occurs in cmake (for now).

FabKlein added a commit to FabKlein/audiomark that referenced this issue Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants