Merges from Laurent's latest drop + cmake platform #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petertorelli
requested review from
llefaucheur
and removed request for
llefaucheur
This was referenced Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the merge of the ZIP file Laurent sent me the last week of September. Not sure how it compares with the two other patch branches that I just noticed. I added a cmake platform and it builds fine with
FIXED_POINTand CMSIS, but fails withFLOATING_POINT. I also think there is a bug on line 400 offfwrap.c. IfFIXED_POINTis enabled, it tries to use floating point libmath functions. Seems like bug, works fine changingifdeftoifndef.