cst: Stop breaking the spec by allowing tab indents for map values

eemeli · Dec 27, 2018 · 572f540 · 572f540
1 parent 94ebaa2
commit 572f540
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/__tests__/corner-cases.js b/__tests__/corner-cases.js
@@ -259,3 +259,12 @@ test('parse an empty string as null', () => {
   const value = YAML.parse('')
   expect(value).toBeNull()
 })
+
+test('fail on map value indented with tab', () => {
+  const src = 'a:\n\t1\nb:\n\t2\n'
+  const doc = YAML.parseDocument(src)
+  expect(doc.errors).toMatchObject([
+    { name: 'YAMLSemanticError' },
+    { name: 'YAMLSemanticError' }
+  ])
+})
diff --git a/src/cst/CollectionItem.js b/src/cst/CollectionItem.js
@@ -31,15 +31,14 @@ export default class CollectionItem extends Node {
     let offset = Node.endOfWhiteSpace(src, start + 1)
     let ch = src[offset]
     while (ch === '\n' || ch === '#') {
-      const next = offset + 1
       if (ch === '#') {
-        const end = Node.endOfLine(src, next)
+        const end = Node.endOfLine(src, offset + 1)
         this.props.push(new Range(offset, end))
         offset = end
       } else {
         atLineStart = true
-        lineStart = next
-        offset = Node.endOfWhiteSpace(src, next) // against spec, to match \t allowed after indicator
+        lineStart = offset + 1
+        offset = Node.endOfIndent(src, lineStart)
       }
       ch = src[offset]
     }