Check for tags & anchors on sequence items before the - indicator (SY6V)

eemeli · Feb 22, 2018 · 93a8a44 · 93a8a44
1 parent 22e4f65
commit 93a8a44
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 3 deletions.
diff --git a/__tests__/yaml-test-suite.js b/__tests__/yaml-test-suite.js
@@ -24,7 +24,6 @@ const skipErrors = [
   '9C9N',
   '9KBC',
   'B63P',
-  'SY6V',
   'ZCZ6',
   'ZL4Z',
 ]

diff --git a/src/ast/Node.js b/src/ast/Node.js
@@ -210,6 +210,16 @@ export default class Node {
     return false
   }
 
+  get hasProps () {
+    if (this.context) {
+      const { src } = this.context
+      for (let i = 0; i < this.props.length; ++i) {
+        if (src[this.props[i].start] !== Char.COMMENT) return true
+      }
+    }
+    return false
+  }
+
   get jsonLike () {
     const jsonLikeTypes = [
       Type.FLOW_MAP,

diff --git a/src/ast/ParseContext.js b/src/ast/ParseContext.js
@@ -111,8 +111,8 @@ export default class ParseContext {
       }
       ch = src[offset]
     }
-    // '- &a : b' has an anchor on an empty PLAIN node
-    if (lineHasProps && Node.atCollectionItem(src, offset)) offset -= 1
+    // '- &a : b' has an anchor on an empty node
+    if (lineHasProps && ch === ':' && Node.atBlank(src, offset + 1)) offset -= 1
     const type = ParseContext.parseType(src, offset, inFlow)
     trace: 'props', type, { props, offset }
     return { props, type, valueStart: offset }

diff --git a/src/schema/Seq.js b/src/schema/Seq.js
@@ -23,6 +23,8 @@ export default class YAMLSeq extends Collection {
           break
         case Type.SEQ_ITEM:
           this.items.push(doc.resolveNode(item.node))
+          if (item.hasProps) doc.errors.push(new YAMLSyntaxError(item,
+            'Sequence items cannot have tags or anchors before the - indicator'))
           break
         default:
           doc.errors.push(new YAMLSyntaxError(item,