Generic argument support for node methods #383
Conversation
golergka
changed the title
|
@golergka I'd like to expand this PR a bit to package in a few more TS changes, including a port of |
Certainly! It's your repo, after all 😁 |
| /** Utility type mapper */ | ||
| export type NodeType<T> = T extends string | number | bigint | boolean | null | ||
| ? Scalar<T> | ||
| : T extends Array<any> | ||
| ? YAMLSeq<NodeType<T[number]>> | ||
| : T extends { [key: string | number]: any } | ||
| ? YAMLMap<NodeType<keyof T>, NodeType<T[keyof T]>> | ||
| : Node |
There was a problem hiding this comment.
This isn't currently publicly exported, but I wonder if it'd be useful outside of createNode()? Also happy to bikeshed on the name.
golergka
force-pushed
the
generic-arguments-for-node-functions
branch
from
c2254de
to
c0db02a
Compare
|
Thank you @golergka! Very happy to have this included. I've a couple of other minor things that I want to get in, but then should be able to get a new release out within a week or so. |
Closes #382
I'd like to add some tests that use types as well, but the relevant test
collection-access.jsis currently untyped, and changing it seemed a little to large a change for a first contribution.