Add parser support for WITH SUCCESSORS and WITH DESCENDANTS keywords #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in order to parse asn files with those without crashing
…CCESSORS_WITH_DESCENDANTS-1 added support for 'WITH SUCCESSORS' and 'WITH DESCENDANTS' in parser …
Codecov Report
@@ Coverage Diff @@
## master #161 +/- ##
=======================================
Coverage 35.18% 35.18%
=======================================
Files 7 7
Lines 8567 8567
=======================================
Hits 3014 3014
Misses 5553 5553 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
eerimoq
reviewed
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to parse ASN1 files that include WITH SUCCESSORS or WITH DESCENDANTS keywords. Currently they are not handled by the parser and compiling those files would crash.
I've tried to make the minimum modification so that compiling files containing those keyword won't crash.
If you think that there is more to do in order to complete the commit, please explain me what to do.
Note : Rust code generation tests are failing, but the result of passing the tests ('make test') is the same on my branch and on your master branch so I believe there is no regression.