Fix warnings when built without CRLE #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building without CRLE, the functions `unpack_usize_init` and `unpack_usize` are not used, resulting in compiler warnings. This patch moves those functions into the DETOOLS_CONFIG_COMPRESSION_CRLE region so that these warnings are not generated when CRLE is disabled.
Codecov Report
@@ Coverage Diff @@
## master #1 +/- ##
=======================================
Coverage 93.56% 93.56%
=======================================
Files 5 5
Lines 1865 1865
=======================================
Hits 1745 1745
Misses 120 120
Continue to review full report at Codecov.
|
|
Thanks! |
|
Btw, may I ask which compression algorithm you are planning to use? |
|
Sure -- heatshrink, because it performs quite well on the binaries I've shown it. I'd use lzma if I could find a library that used similarly small amounts of memory. |
|
Ok, I added support for it for exactly that reason. I'm glad you found it useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building without CRLE, the functions
unpack_usize_initandunpack_usizeare not used, resulting in compiler warnings. Thispatch moves those functions into the DETOOLS_CONFIG_COMPRESSION_CRLE
region so that these warnings are not generated when CRLE is
disabled.