-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradle 7.1.1 compat #32
Conversation
Added eclipse project settings for the buildship plugin and groovy. Ignore bin and classpath+project files since Gradle generates these. Added gradle.properties to enable caching and specify JVM args. Fix issues with Gradle 7.1.1 in the Groovy plugin code, including: - Add getters for newly @Input/@internal properties. - Add @input and @internal appropriately to properties to comply with 7.1.1.
Remove jcenter bintray as repo since it got shut down. Fix gradle migration issues: - Work around gradle duplicate-no-duplicate issue by including duplicates. - testCompile to testCompileOnly, since testCompile got completely removed in 7.0.0.
Add eclipse plugin with SpotBugs nature+builder.
There's a bunch of changes here that don't seem related to Gradle 7.1.1 compatibility. The Eclipse stuff, for instance. Can you explain how the plugin currently isn't compatible with Gradle 7.1.1 and how the changes here fix it? |
Upgraded the wrapper to 7.1.1.
Removed eclipse sections that are not required for Gradle 7.1.1.
@eerohele Good point. I can remove that stuff. I have the following list of changes required to make the build compatible with Gradle 7+:
Let me know if this is sufficient information or not. Jon |
Need a repo to get deps. Whoops.
The result of running the build on 7.1.1 is the following, with --no-build-cache and --rerun-tasks to ensure everything works:
Here's the build result: |
In regard to src/main/groovy/com/github/eerohele/SaxonXsltTask.groovy, the plugin would not build in 7.1.1 without the added annotations and getters. |
These are not required for Gradle 7+.
@eerohele Is this PR ok now? |
@jhyry-gcpud Sorry for the delay. Life keeps getting in the way. I looked into it a bit, and I think I fixed most of the Gradle 7 compatibility issues. I've published v0.9.0-beta4 into the Gradle plugin portal if you want to give it a try. After these changes, I don't get any deprecation warnings regarding the |
I very much understand life getting in the way. |
@eerohele Works like a charm! Thanks again! |
Cool, thanks for reporting back! |
Fix for compatibility with Gradle 7.1.1.