Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanups and iterator #5

Merged
merged 17 commits into from May 7, 2018
Merged

Cleanups and iterator #5

merged 17 commits into from May 7, 2018

Conversation

federicomenaquintero
Copy link
Contributor

This pull request has several things:

  • shapeops::compute() now takes a slice, not a &Vec.
  • Fix a ton of compiler warnings, to get a clean build.
  • Make Contour::iter_segments() return something that implements Iterator, instead of copying a new vector.
  • Adds a couple of tests for iter_segments() for cargo test.
  • Wires do_flip() in the main program; I think this was just an oversight?

@federicomenaquintero
compute(): Allow taking a slice of Polygon
9046b43
@federicomenaquintero
shapeops: Add a test for iterating over the segments of an empty contour
902e2c0
@federicomenaquintero
shapeops: Test that contour.iter_segments() matches each individual c…
781c334 
…ontour.segment()

We add #[derive(PartialEq)] to Segment2 so that they can be compared
with == to each other.
@federicomenaquintero
Remove unused imports
7c32ef1
@federicomenaquintero
Prefix unused variables with _ so they don't cause warnings
408c2e0
@federicomenaquintero
idchoppers: Wire the "flip" command to its function
584a511 
It seems to have been forgotten?
@federicomenaquintero
Remove 'mut' from variables that don't need to be mutable
75aeaf7
@federicomenaquintero
Prefix unused struct fields with _
25fe23f
@federicomenaquintero
Comment out unused constant
c0d2c5c 
It's used in code that is commented out
@federicomenaquintero
Prefix unused methods with _
71ebc12
@federicomenaquintero
Prefix unused statics with _
2480fa9
@federicomenaquintero
Prefix unused consts with _
9d1963e
@federicomenaquintero
Prefix more unused struct fields with _
ea23258
@federicomenaquintero
Turn camelCase function names into snake_case
689d5ed 
Other names were already in snake_case; if you really want the former
you can use #![allow(non_snake_case)] in the module toplevel.
@federicomenaquintero
expect() a Result instead of just dropping it on the floor
ca25aa8
@federicomenaquintero
Contour::iter_segments() - return an iterator, not a new Vec
c11567c
@federicomenaquintero
ContourSegment: implement directly without using Contour.segment()
1e2d4fb
@eevee eevee merged commit 9827f75 into eevee:master May 7, 2018
@eevee
Copy link
Owner

eevee commented May 7, 2018

Hey, thanks for cleaning up stuff I'd been putting off :)

@federicomenaquintero
Copy link
Contributor Author

Thanks for the merge!

I'd like to continue cleaning this up, but I'm not sure about some things:

  • How do I test this? Should I get some WADs from somewhere and just see what happens? (Do you have some links to WAD formats and such? I haven't worked on Doom maps for... many years) :)
  • What would you like me to look at? I'd prefer "general Rust stuff that you want cleaned up but haven't gotten around to doing it" rather than "fix the WAD logic", since I will take some time to learn the latter :)

@eevee
Copy link
Owner

eevee commented May 8, 2018

Hm, I don't know if much more cleanup is really worth it (or possible!) until I figure out exactly what I want this to do for an 0.1 release and get it working — there are a whole lot of things started on but not finished. I do welcome any feedback on stuff I start doing, though, and tests are certainly a good idea...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@federicomenaquintero @eevee