Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hooking in CircleCI #1

Merged
merged 3 commits into from
Nov 12, 2019
Merged

Hooking in CircleCI #1

merged 3 commits into from
Nov 12, 2019

Conversation

swade1987
Copy link

@swade1987 swade1987 commented Nov 12, 2019

@swade1987 swade1987 requested a review from a team November 12, 2019 16:09
@@ -0,0 +1,26 @@
APP_NAME=burrow

QUAY_REPO?="unknown"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you setting this in Circle env vars?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

Copy link

@gavinmcnair gavinmcnair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swade1987 swade1987 merged commit b0424fa into master Nov 12, 2019
@swade1987 swade1987 deleted the circleci branch November 12, 2019 16:27
swade1987 pushed a commit that referenced this pull request May 15, 2020
Add SASL-SCRAM ability to Kafka connection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants