Explicitly set script_dir since references expect it to point to the directory containing fixed_wrapper_cfgs.tcl #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…directory containing fixed_wrapper_cfgs.tcl Signed-off-by: Matthew Ballance <matt.ballance@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm following the integration flow in caravel_user_project, with the caravel subproject pointing to caravel-lite. I receive an error about the pin_order.tcl file if fixed_wrapper_cfgs.tcl does not set script_dir internally. This PR resolves the issue.
My understanding is that changes to caravel are propagated to caravel-lite. Please let me know if I need to take additional action to get this change made to caravel-lite.
Best Regards,
Matthew
Signed-off-by: Matthew Ballance matt.ballance@gmail.com