Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream antenna patch #405

Closed
mole99 opened this issue Mar 4, 2024 · 4 comments
Closed

Upstream antenna patch #405

mole99 opened this issue Mar 4, 2024 · 4 comments
Assignees
Labels
OpenROAD This issue relates to a built-in step or flow using OpenROAD
Milestone

Comments

@mole99
Copy link
Contributor

mole99 commented Mar 4, 2024

Description

Are there any plans to upstream this patch here: nix/patches/openroad/antenna.patch

Using a locally compiled OpenROAD without it leads to a failure in Odb.CheckDesignAntennaProperties:

Error Message
AttributeError: 'dbMTerm' object has no attribute 'hasDiffArea'. Did you mean: 'getDiffArea'?                                                                                        
[09:11:34] ERROR      File "/usr/lib/python3/dist-packages/click/core.py", line 754, in invoke                                                                           step.py:1170
                        return __callback(*args, **kwargs)                                                                                                                           
                      File "/usr/local/lib/python3.10/dist-packages/openlane/scripts/odbpy/reader.py", line 205, in wrapper                                                          
                        function(**kwargs)                                                                                                                                           
                      File "/usr/local/lib/python3.10/dist-packages/openlane/scripts/odbpy/check_antenna_properties.py", line 109, in check_antenna_properties                       
                        report = check_cells(cells)                                                                                                                                  
                      File "/usr/local/lib/python3.10/dist-packages/openlane/scripts/odbpy/check_antenna_properties.py", line 34, in check_cells                                     
                        has_diff_area = mterm.hasDiffArea()                                                                                                                          
                    AttributeError: 'dbMTerm' object has no attribute 'hasDiffArea'. Did you mean: 'getDiffArea'?

Thanks!

Proposal

Upstream the patch to OpenROAD

@donn
Copy link
Member

donn commented Mar 4, 2024

@kareefardi I think we discussed upstreaming this but we stalled because we were busy with release…? What's the status on this?

@kareefardi
Copy link
Collaborator

The-OpenROAD-Project/OpenROAD#4733

@donn donn added the OpenROAD This issue relates to a built-in step or flow using OpenROAD label Mar 4, 2024
@kareefardi
Copy link
Collaborator

This will likely be address by #436

@donn
Copy link
Member

donn commented Jul 3, 2024

Done in dev

@donn donn closed this as completed Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OpenROAD This issue relates to a built-in step or flow using OpenROAD
Projects
None yet
Development

No branches or pull requests

3 participants