Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liberty: Fix bit_... fields in bus definitions #7

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

ubfx
Copy link

@ubfx ubfx commented Mar 5, 2024

The Liberty User Guide specifies these fields to be integers, but they are currently given as floats in the .lib-files, leading to problems with some tools.

Example before fix:

type ("bus8") {
        base_type : "array";
        bit_from : 7.0000000000;
        bit_to : 0.0000000000;
        bit_width :  8.000000000;
[...]

Fix #6

The Liberty User Guide specifies these fields to be integers, but they
are currently given as floats in the .lib-files, leading to problems with
some tools.
@ubfx
Copy link
Author

ubfx commented Mar 8, 2024

I also checked all other logic libraries, and this (hdll) seems to be the only one where this is a problem. All others are already using integers.

@RTimothyEdwards
Copy link

I can work on this after I merge the pull request for the cut layer issue, unless you have a pull request for this waiting.

@RTimothyEdwards
Copy link

Sorry, I see the pull request. Somehow until I refreshed my browser I didn't see any files changed. So I'll go ahead and review.

Copy link

@RTimothyEdwards RTimothyEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me.

@RTimothyEdwards RTimothyEdwards merged commit 41b69ed into efabless:master Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Liberty files: bit_from/... illegaly given as floats
2 participants