-
-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
H264 issues #170
Comments
Maybe building the 51 branch is worth it, I see it also includes the H264 fixes, and maybe it's more stable? https://chromium.googlesource.com/external/webrtc/+log/branch-heads/51/ |
I gave it a try too and get a green screen but I don't see those debug statements. Did you use cordova or taco (the cordova wrapper with livereload?), if so, let me know. I'll try and replicate it with Cordova as well. |
Hi @MaartenPI, I use Cordova directly. |
I gave Cordova and Xcode a try, both give the same result as taco, without any problematic debug messages. Not really sure on how to debug this further. |
h264 is a no-go for me here too, even without Cordova entirely. I tried rebuilding the library on the latest release 12799 as well. Apparently the EAGLView calls a number of functions like stride, uv, etc. CoreVideoFrameBuffer does not implement these functions so it calls the parent NativeFrameBuffer implementation, which is basically this: ` int NativeHandleBuffer::StrideY() const { It crashes in the debug build when it hits RTC_NOTREACHED(). On release build, it shows a green screen since they simply return zeros. I'm not sure if this is an oversight or simply the fact that h264 isn't ready for iOS :( |
@hasbean Interesting find! The weird part is that with previous releases we got some really bizarre quality (~10fps) whereas now we get a crash. So, in some way it looked ready-ish, but I haven't dug deep enough. It's surprising that you end up there, while we used to get H264 video before, albeit with ~10fps. |
Closed by error. Reopening. |
Potentially relevant: #193 (comment) |
Has any of you been able to solve the green screen issue by recompiling the plugin with the latest libraries ? before going through the exercise, wanted to make sure is worth while ;) |
@BellesoftConsulting Did you try this? I have the same issue. |
nope, did not get it work :(
…On Sun, May 27, 2018 at 1:45 PM Eivind Lindbråten ***@***.***> wrote:
@BellesoftConsulting <https://github.com/BellesoftConsulting> Did you try
this? I have the same issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#170 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AVZ67vttTC6xepGCvKm14QUDTejHJS4uks5t2uZOgaJpZM4IVXKY>
.
|
No sure but should be fixed by M69 PR #399 |
Confirmed H264 support on #399 via FreeSwitch and jssip |
Sooo, I have some sad news :-(
It only happens when using H264, so there is that. Did anyone run into the same thing after the last update?
The text was updated successfully, but these errors were encountered: