Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration support #23

Merged
merged 57 commits into from
Jan 28, 2019
Merged

Migration support #23

merged 57 commits into from
Jan 28, 2019

Conversation

simon-reynolds
Copy link
Collaborator

Initial support for migrations and scaffolding

Definitely alpha quality, we have a number of outstanding issues to address such as #20 and #21
On more of a housekeeping note more unit tests are also required (#22)

@bricelam I know F# isn't your forte, if there is anyone else you feel would be able to take a look at this please add them

Most of the functionality is still stubbed and will not produce any working code
Need to change how FSharpMigrationsGenerator is implemented to include all of migration in single file
FSharpMigrationsGenerator now implemented as a module rather than a type inheriting from MigrationsCodeGenerator
This was referenced Jan 25, 2019
Copy link
Member

@bricelam bricelam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks for all your work on this! I skimmed through it and didn't see any gaping issues.

@simon-reynolds simon-reynolds merged commit eb3e240 into master Jan 28, 2019
@simon-reynolds
Copy link
Collaborator Author

Closes #2 #3 and #19

@simon-reynolds simon-reynolds deleted the migration-support branch February 3, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants