-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration support #23
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the functionality is still stubbed and will not produce any working code
… Migration.fs and Migration.Designer.fs
Need to change how FSharpMigrationsGenerator is implemented to include all of migration in single file
FSharpMigrationsGenerator now implemented as a module rather than a type inheriting from MigrationsCodeGenerator
… to current EF Core behavior
Proposed changes to stay closer to standard EF Core behavior
Other cleanup work included
Start adding support for handling expressions
Also includes some WIP tests which are currently disabled
Now creates scaffolded files but they are broken
bricelam
approved these changes
Jan 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, thanks for all your work on this! I skimmed through it and didn't see any gaping issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial support for migrations and scaffolding
Definitely alpha quality, we have a number of outstanding issues to address such as #20 and #21
On more of a housekeeping note more unit tests are also required (#22)
@bricelam I know F# isn't your forte, if there is anyone else you feel would be able to take a look at this please add them