Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*Any* amount of DAI is accepted as payment #17

Closed
pipermerriam opened this issue Jul 8, 2019 · 1 comment
Closed

*Any* amount of DAI is accepted as payment #17

pipermerriam opened this issue Jul 8, 2019 · 1 comment

Comments

@pipermerriam
Copy link
Collaborator

Currently, the code which would accept DAI based payments doesn't verify that the appropriate amount was sent.

https://github.com/esPass/pretix-eth-payment-plugin/blob/eedcd5c562f5afb66cc761a3409f88476fdb9118/pretix_eth/payment.py#L142-L143

With the lines above commented out, a user could send any amount of DAI and successfully purchase a ticket.
@pipermerriam pipermerriam mentioned this issue Jul 9, 2019
Merged
@ligi
Copy link
Member

ligi commented Sep 24, 2021

This is not the case anymore

@ligi ligi closed this as completed Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ligi @pipermerriam