-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#4 provide default checks #41
base: master
Are you sure you want to change the base?
Feature/#4 provide default checks #41
Conversation
Thank you for the PR. Please be patient, I'll try to look into it the week after the next. |
* @return self for methodChaining | ||
*/ | ||
public Check matchesRegexCheck(StringProperty property, Severity severity, Node decorated, String regex) { | ||
Function<String, String> messageCreator = string -> String.format("%s['%s'] does not match the regex %s", property.getName(), string, regex); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a problem for i18n. We must not provide any natural language strings from within ValidatorFX.
I had another look at this PR and I'm not sure if I want to integrate it the way it stands. The problems I found:
So overall I think I'll use this PR as a good base / inspiration of what is wanted but will try to come up with an implementation that is more in line with the (undocumented, implicit ...) design ideas behind ValidatorFX. |
…leCheck, use ObservableValue as base for all checks
I attempted to address your concerns regarding my pull request:
If you can spare the time, you could reevaluate whether the PR now fits your ideas behind ValidatorFX more closely, otherwise I think using the methods in this PR as inspiration for a future enhancement is fine as well. |
Providing a base implementation for #4