Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can not create batches for campaigns with 0 EFX reward #114

Open
jeisses opened this issue Jun 22, 2023 · 1 comment
Open

Can not create batches for campaigns with 0 EFX reward #114

jeisses opened this issue Jun 22, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@jeisses
Copy link
Member

jeisses commented Jun 22, 2023

Feature

It should be possible to create campaign with 0 rewards.

At the moment this is not possible (there is a silent failure in the UI, with an error printed to the console related to "transfer positive quantity)"

This is most likely because the smart contract tries to send a 10% fee (which amounts to 0). The fee should be skipped for free campaigns.
@jeisses jeisses added the bug Something isn't working label Jun 22, 2023
@jeisses
Copy link
Member Author

jeisses commented Jun 22, 2023

I published a fix at e8d1f03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeisses