Skip to content

Commit

Permalink
hotfix: Release 1.0.0 deploy error 해결 (#44)
Browse files Browse the repository at this point in the history
* fix: 변경된 s3 url 적용

* fix: useShowLoginModal prop undefined 에러 임시 조치

* feat: useModal Dimmer 반응형 적용

* fix: useQuestionAnswer hook api import 에러 해결

* fix: useModal import warning 해결

* feat: title ,description seo 추가

* fix: page api 캐싱으로 인해 이전 질문이 잠시 보이는 문제 해결
  • Loading branch information
L2HYUNN committed Mar 23, 2023
1 parent 71b2d91 commit 93732dc
Show file tree
Hide file tree
Showing 8 changed files with 19 additions and 5 deletions.
2 changes: 1 addition & 1 deletion next.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const nextConfig = {
remotePatterns: [
{
protocol: 'https',
hostname: 'sparcs-2023-startup-hackathon-f-1.s3.ap-northeast-2.amazonaws.com',
hostname: 's3.ap-northeast-2.amazonaws.com',
},
],
},
Expand Down
2 changes: 1 addition & 1 deletion src/components/common/Header/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { css } from '@emotion/react';
import styled from '@emotion/styled';

import { GoBackModal } from '~/components/question/GoBackModal';
import useModal from '~/hooks/useModal';
import { useModal } from '~/hooks/useModal';
import { theme } from '~/styles/Theme';

import { Icon } from '../Icon';
Expand Down
1 change: 1 addition & 0 deletions src/hooks/query/usePagesQuery.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ export const usePagesQuery = () => {
const pagesQuery = useQuery({
queryKey: PAGES_QUERY_KEYS.getPages,
queryFn: () => getPages(),
cacheTime: 0,
});

return pagesQuery;
Expand Down
4 changes: 2 additions & 2 deletions src/hooks/query/useQuestionAnswerQuery.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import { useQuery } from '@tanstack/react-query';

import { getQuestionAnswer } from '~/apis';
import { getQuestionAnswerDeprecated } from '~/apis';
import { QUESTION_ANSWER_QUERY_KEYS } from '~/constants/queryKeys';

export const useQuestionAnswerQuery = (questionId?: number) => {
const questionAnswerQuery = useQuery({
queryKey: QUESTION_ANSWER_QUERY_KEYS.getQuestionAnswer(questionId),
queryFn: () => getQuestionAnswer(questionId),
queryFn: () => getQuestionAnswerDeprecated(questionId),
});
return questionAnswerQuery;
};
7 changes: 7 additions & 0 deletions src/hooks/useModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ import styled from '@emotion/styled';
import { useOverlay } from '@toss/use-overlay';
import type { ComponentProps } from 'react';

import { theme } from '~/styles/Theme';

import { Modal } from '../components/common/Modal';

export function useModal() {
Expand Down Expand Up @@ -45,4 +47,9 @@ const Dimmer = styled.div`
height: 100%;
top: 0%;
background-color: rgba(0, 0, 0, 0.5);
${theme.mediaQuery.desktop} {
width: 360px;
z-index: 9999;
}
`;
2 changes: 1 addition & 1 deletion src/hooks/useShowLoginModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { ConfirmModal } from '~/components/common/ConfirmModal';

import { useModal } from './useModal';

export function useShowLoginModal(redirectUrl: string) {
export function useShowLoginModal(redirectUrl?: string) {
const { openModal } = useModal();
const router = useRouter();

Expand Down
1 change: 1 addition & 0 deletions src/pages/_app.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ export default function App({ Component, pageProps }: AppProps<PageProps>) {
return (
<>
<Head>
<title>이펙티브 기술면접 - ChatGPT로 연습하는 개발자 면접</title>
<script async src={`https://www.googletagmanager.com/gtag/js?id=${gtag.GA_TRACKING_ID}`} />

{/* GA설정 */}
Expand Down
5 changes: 5 additions & 0 deletions src/pages/_document.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ export default function Document() {
return (
<Html lang="en">
<Head />
<meta
name="description"
content="프론트엔드, 백엔드 면접 막막하다면? 개발 언어만 선택하면 10초만에 맞춤 질문을 뽑아드려요. 답변이 어려운 꼬리 질문까지, AI로 면접 준비 한번에!"
/>

<link
rel="icon"
href="https://effective-tech-client-assets.s3.ap-northeast-2.amazonaws.com/logo-blue.svg"
Expand Down

0 comments on commit 93732dc

Please sign in to comment.