Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typescript react typings #32

Closed
zerobias opened this issue Jan 22, 2019 · 1 comment
Closed

typescript react typings #32

zerobias opened this issue Jan 22, 2019 · 1 comment
Labels
effector-react effector-react package help wanted Extra attention is needed typings Typescript public type definitions issues

Comments

@zerobias
Copy link
Member

Code to reproduce the issue:
here and further
https://github.com/zerobias/effector/blob/master/packages/effector-react/index.d.ts#L16

Expected behavior:
typescript uses React.ReactNode type

Actual behavior:
React.Node, which not exists in typescript's react typings

Versions of packages used:
0.18.0
@zerobias zerobias added help wanted Extra attention is needed typings Typescript public type definitions issues labels Jan 22, 2019
@zerobias
Copy link
Member Author

fixed in c72d5d1

@goodmind goodmind added the effector-react effector-react package label Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effector-react effector-react package help wanted Extra attention is needed typings Typescript public type definitions issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@goodmind @zerobias