Fix bug

- Add test case - Add check length for this case
effector · May 13, 2023 · aa88db5 · aa88db5
1 parent 787f2d4
commit aa88db5
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/.../enforce-store-naming-convention/prefix/enforce-store-naming-convention-prefix.ts.test.js b/.../enforce-store-naming-convention/prefix/enforce-store-naming-convention-prefix.ts.test.js
@@ -25,7 +25,9 @@ ruleTester.run(
   "effector/enforce-store-naming-convention-prefix.ts.test",
   rule,
   {
-    valid: ["correct-store-naming.ts"].map(readExampleForTheRule),
+    valid: ["correct-store-naming.ts", "correct-issue-139.ts"].map(
+      readExampleForTheRule
+    ),
 
     invalid: [
       // Errors

diff --git a/rules/enforce-store-naming-convention/prefix/examples/correct-issue-139.ts b/rules/enforce-store-naming-convention/prefix/examples/correct-issue-139.ts
@@ -0,0 +1,3 @@
+import { createStore } from "effector";
+
+const $ = createStore(0);
diff --git a/utils/naming.js b/utils/naming.js
@@ -14,7 +14,7 @@ function isStoreNameValid({ name, context }) {
   const storeNameConvention = getStoreNameConvention(context);
 
   // validate edge case
-  if (name?.startsWith("$") && name?.endsWith("$")) {
+  if (name?.length > 1 && name?.startsWith("$") && name?.endsWith("$")) {
     return false;
   }