Remove combine-method from effect creatios list (#26)

effector · Aug 30, 2021 · d53c3d3 · d53c3d3
1 parent 5aef3ca
commit d53c3d3
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/rules/enforce-effect-naming-convention/enforce-effect-naming-convention.js b/rules/enforce-effect-naming-convention/enforce-effect-naming-convention.js
@@ -55,7 +55,7 @@ module.exports = {
       },
       CallExpression(node) {
         // Effect creation with method
-        const EFFECT_CREATION_METHODS = ["createEffect", "attach", "combine"];
+        const EFFECT_CREATION_METHODS = ["createEffect", "attach"];
         for (const method of EFFECT_CREATION_METHODS) {
           const localMethod = importedFromEffector.get(method);
           if (!localMethod) {

diff --git a/rules/enforce-effect-naming-convention/enforce-effect-naming-convention.test.js b/rules/enforce-effect-naming-convention/enforce-effect-naming-convention.test.js
@@ -18,6 +18,7 @@ ruleTester.run("effector/enforce-effect-naming-convention.test", rule, {
     "correct-effect-naming.js",
     "correct-effect-naming-from-other-package.js",
     "correct-effect-naming-in-domain.js",
+    "correct-examples-01.js",
   ]
     .map(readExampleForTheRule)
     .map((code) => ({ code })),

diff --git a/rules/enforce-effect-naming-convention/examples/correct-examples-01.js b/rules/enforce-effect-naming-convention/examples/correct-examples-01.js
@@ -0,0 +1,11 @@
+import { combine } from "effector";
+
+// Examples were found in production code-base with false-poitive detection on 0.1.2
+
+const $sourceOrDefault = combine($source, $allSources, (source, allSources) => {
+  if (!source || source.length === 0) {
+    return head(allSources) ?? "Freelance";
+  }
+
+  return source;
+});