Fix enforce-store-naming-convention rule#119
Merged
igorkamyshev merged 3 commits intoeffector:masterfrom Sep 5, 2022
Merged
Conversation
igorkamyshev
requested changes
Aug 30, 2022
enforce-store-naming-convention rule
Member
|
Thanks for tests 🙏 I've found out that in this rule, previously written tests are stored in subdirectories Should we move this cases to the same files and extend case on suffix notation as well? |
igorkamyshev
approved these changes
Sep 5, 2022
Member
igorkamyshev
left a comment
There was a problem hiding this comment.
Amazing, thanks!
Will be released in an hour 💙
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current
enforce-store-naming-conventionrule passes this case, but it is not correct:Same for the domain use case:
This PR fixes this incorrect behavior