rule no-patronum-debug
#121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeysova
approved these changes
Sep 8, 2022
Member
|
If you going to merge, please consider squashing all commits |
Member
|
@raidenmiro Thank you for the contribution! |
igorkamyshev
reviewed
Sep 9, 2022
Member
igorkamyshev
left a comment
igorkamyshev
left a comment
There was a problem hiding this comment.
Thanks for amazing implementation. I love these docs and the number of tests 💙
I have one minor question, everything else is great.
Establish patronum in the dependency Add tests for rule `no-patronum-debug` Add examples with typescript and tests Add patronum preset to the config Add a section in the docs about patronum and `no-patronum-debug` rule
igorkamyshev
approved these changes
Sep 12, 2022
Member
igorkamyshev
left a comment
igorkamyshev
left a comment
There was a problem hiding this comment.
Great, thanks 💙
Will be released in an hour ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #112