Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rule no-patronum-debug #121

Merged
merged 1 commit into from Sep 12, 2022
Merged

rule no-patronum-debug #121

merged 1 commit into from Sep 12, 2022

Conversation

raidenmiro
Copy link
Contributor

closes #112

  • - basic test-cases
  • - implementation
  • - ts examples
  • - docs

@sergeysova
Copy link
Collaborator

sergeysova commented Sep 8, 2022 •
edited

If you going to merge, please consider squashing all commits

@sergeysova
Copy link
Collaborator

sergeysova commented Sep 8, 2022 •
edited

@raidenmiro Thank you for the contribution!

igorkamyshev
igorkamyshev reviewed Sep 9, 2022
View reviewed changes
Copy link
Member

@igorkamyshev igorkamyshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for amazing implementation. I love these docs and the number of tests 💙

I have one minor question, everything else is great.

rules/no-patronum-debug/no-patronum-debug.js Outdated Show resolved Hide resolved
@raidenmiro
Implement rule no-patronum-debug
dda87d6 
Establish patronum in the dependency

Add tests for rule `no-patronum-debug`

Add examples with typescript and tests

Add patronum preset to the config

Add a section in the docs about patronum and `no-patronum-debug` rule
igorkamyshev
igorkamyshev approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@igorkamyshev igorkamyshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks 💙

Will be released in an hour ✅

@igorkamyshev igorkamyshev merged commit f7b99c9 into effector:master Sep 12, 2022
@raidenmiro raidenmiro deleted the rule-no-patronum-debug branch September 12, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeysova sergeysova sergeysova approved these changes

@igorkamyshev igorkamyshev igorkamyshev approved these changes

Assignees

@igorkamyshev igorkamyshev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule: no-patronum-debug
3 participants
@raidenmiro @sergeysova @igorkamyshev